chanzuckerberg / idseq-workflows

Portable WDL workflows for IDseq production pipelines
https://idseq.net/
MIT License
31 stars 12 forks source link

Update ivar trim to address issues with trimming in SWIFT/SNAP protocol #90

Closed katrinakalantar closed 3 years ago

katrinakalantar commented 3 years ago

A fix was recently implemented in iVar v. 1.3.1 that addresses an issue with trimming that was identified for some amplicon-based sequencing protocols (e.g. SWIFT, SNAP), where polymerases can add additional bases and lead mismatches.

Prior to this change, the Dockerfile was updated to include this latest version of iVar (https://github.com/chanzuckerberg/idseq-workflows/pull/84). This PR updates the ivar trim call in the TrimPrimers step to leverage the recent change. In particular, it makes the ivar trim command dependent on the primer trimming .bed file. For the SNAP protocol (snap_primers.bed) we now implement a 5-bp offset, consistent with recommendation from the developers of iVar. For all remaining supported primer sets (not polymerase-based) we do not use the primer offset.

This PR also includes one additional test to verify the parameter's impact on downstream depth of coverage for a test SNAP dataset.

Testing