chanzuckerberg / napari-hub

Discover, install, and share napari plugins
MIT License
50 stars 18 forks source link

Subscribe button is not responsive #1284

Closed lmarcos closed 11 months ago

lmarcos commented 11 months ago

Description

Subscribe button is not responsive

Steps/Code to Reproduce

  1. Go to https://www.napari-hub.org/
  2. Navigate to bottom of page
  3. Enter correct email address in "Sign up to receive updates" section
  4. Click on button

Expected Results

Thanks for subscribing message should be displayed

Actual Results

Nothing happens

https://github.com/chanzuckerberg/napari-hub/assets/7291920/aa4cac65-7d97-401a-ab82-c58647f01959

richaagarwal commented 11 months ago

@lauramarcos This worked for me when I tested it just now - perhaps it's an intermittent issue? Are you able to reproduce again?

lmarcos commented 11 months ago

it is still not working for me and I already tried other browsers @richaagarwal

richaagarwal commented 11 months ago

I've tried Safari & Chrome and they are both working for me. I also tried after navigating to different pages of search results. Which browsers have you tried @lmarcos?

@manasaV3 or @codemonkey800 could one of you see if you're able to reproduce?

richaagarwal commented 11 months ago

Oh, I think it may be the e-mail address you are trying to use @lmarcos - have you always tested with @test.com ? It seems like we may be validating or filtering that out somehow. Using @test.com doesn't work for me either. cc @codemonkey800

codemonkey800 commented 11 months ago

It seems like we may be validating or filtering that out somehow

@richaagarwal @lauramarcos I think this is the case, entering an email that ends with @test.com doesn't trigger a network request to submit the email, while using another email does. If this worked in the past, it's possible HubSpot updated their script without us knowing 😢 we unfortunately can't use a specific version, so we're at HubSpot's whim whenever they make a code change:

https://github.com/chanzuckerberg/napari-hub/blob/9fdf2ad0af3f054a1f5492fe50d59d91cd1e162c/frontend/src/pages/_app.tsx#L88-L93

this has impacted us in the past and has required continuous maintenance on the signup form 😢 maybe in the meantime we could disable the submit button for @test.com emails?

richaagarwal commented 11 months ago

@codemonkey800 thanks for looking into it! I'm going to close this issue out because I think this is enough of an edge case and wouldn't block real users from subscribing.

@lauramarcos it would still be helpful to know if you've always used this laura@test.com to test this, but going forward could you test with a real e-mail address? feel free to use one of ours :)

lmarcos commented 11 months ago

i used to text this feature with laura@test.com and used to work, but I will test with normal domain going forward... thank you both @richaagarwal @codemonkey800