search

chanzuckerberg / redis-memo

A Redis-based version addressable caching system. Memoize pure functions, aggregated database queries, and 3rd party API calls.
https://rubygems.org/gems/redis-memo
MIT License
33 stars 3 forks source link

Log errors and call error handler on invalidation #60

Closed katyho closed 3 years ago

katyho commented 3 years ago

Summary

I think it'd be helpful to use the error handler/log errors on invalidation. We still haven't figured out why rspecs are sometimes flaky with redis-memo - while we see cache out of date errors, we don't see any invalidation errors.

codecov[bot] commented 3 years ago

Codecov Report

Merging #60 (972115d) into main (8492ded) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #60   +/-   ##
=======================================
  Coverage   97.31%   97.32%           
=======================================
  Files          34       34           
  Lines        2125     2127    +2     
=======================================
+ Hits         2068     2070    +2     
  Misses         57       57
Impacted Files Coverage Δ
lib/redis_memo/memoizable/invalidation.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8492ded...15208d7. Read the comment docs.