Closed Dingying0410 closed 3 years ago
Merging #62 (56c39e2) into main (8492ded) will increase coverage by
0.05%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 97.31% 97.37% +0.05%
==========================================
Files 34 34
Lines 2125 2283 +158
==========================================
+ Hits 2068 2223 +155
- Misses 57 60 +3
Impacted Files | Coverage Δ | |
---|---|---|
lib/redis_memo/memoize_query/cached_select.rb | 93.33% <100.00%> (-0.70%) |
:arrow_down: |
spec/memoize_query_spec.rb | 100.00% <100.00%> (ø) |
|
lib/redis_memo/middleware.rb | 27.27% <0.00%> (-6.07%) |
:arrow_down: |
lib/redis_memo.rb | 97.05% <0.00%> (ø) |
|
lib/redis_memo/memoizable/invalidation.rb | 100.00% <0.00%> (ø) |
|
lib/redis_memo/memoize_query.rb | 97.95% <0.00%> (+0.90%) |
:arrow_up: |
spec/cache_spec.rb | 98.03% <0.00%> (+1.02%) |
:arrow_up: |
lib/redis_memo/cache.rb | 100.00% <0.00%> (+1.78%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8492ded...56c39e2. Read the comment docs.
Summary
This PR enables queries with that has both NOT and other bound queries.
Previously we decided to not to cache any queries with NOT, however, queries with both NOT and other bound queries can be cached. E.g
My current approach is to return
bind_params
when we parse anotequal
statement, so thatTest plan
rspec