search

chanzuckerberg / redis-memo

A Redis-based version addressable caching system. Memoize pure functions, aggregated database queries, and 3rd party API calls.
https://rubygems.org/gems/redis-memo
MIT License
33 stars 3 forks source link

[CI] Run rubocop for each build #79

Closed donaldong closed 3 years ago

donaldong commented 3 years ago

Summary

This fixes/disables lint errors we have and enables running rubocop for each build.

Test Plan

codecov[bot] commented 3 years ago

Codecov Report

Merging #79 (cec62b0) into main (e7ac1d6) will increase coverage by 0.04%. The diff coverage is 99.03%.

:exclamation: Current head cec62b0 differs from pull request most recent head 8a71ed2. Consider uploading reports for the commit 8a71ed2 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   97.59%   97.63%   +0.04%     
==========================================
  Files          40       40              
  Lines        2325     2328       +3     
==========================================
+ Hits         2269     2273       +4     
+ Misses         56       55       -1
Impacted Files Coverage Δ
lib/redis_memo/options.rb 88.13% <66.66%> (ø)
lib/redis_memo.rb 97.56% <100.00%> (ø)
lib/redis_memo/batch.rb 100.00% <100.00%> (ø)
lib/redis_memo/cache.rb 98.41% <100.00%> (+0.02%) :arrow_up:
lib/redis_memo/connection_pool.rb 100.00% <100.00%> (ø)
lib/redis_memo/future.rb 98.36% <100.00%> (ø)
lib/redis_memo/memoizable/dependency.rb 100.00% <100.00%> (ø)
lib/redis_memo/memoizable/invalidation.rb 100.00% <100.00%> (ø)
lib/redis_memo/memoize_method.rb 98.03% <100.00%> (ø)
lib/redis_memo/memoize_query.rb 97.05% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7ac1d6...8a71ed2. Read the comment docs.