donaldong commented 3 years ago

Summary

Currently, we're printing way too many debug logs. Those logs are hardly useful to anyone unless they're developing redis-memo.

We can simply remove those Redis logs and display an overall query latency. Note the latency is an over-estmation. It includes more than just the time spent on the redis round trips

codecov[bot] commented 3 years ago

Codecov Report

Merging #95 (7483830) into main (8e7d362) will decrease coverage by 0.03%. The diff coverage is 71.42%.

:exclamation: Current head 7483830 differs from pull request most recent head 66efc62. Consider uploading reports for the commit 66efc62 to get more accurate results

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
- Coverage   98.33%   98.29%   -0.04%     
==========================================
  Files          41       41              
  Lines        2577     2577              
==========================================
- Hits         2534     2533       -1     
- Misses         43       44       +1

Impacted Files	Coverage Δ
lib/redis_memo/redis.rb	`92.30% <ø> (-0.72%)`	:arrow_down:
.../memoize_query/cached_select/connection_adapter.rb	`90.47% <71.42%> (-3.65%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8e7d362...66efc62. Read the comment docs.