chanzuckerberg / sci-components

2021 Science Design System Component Library
https://chanzuckerberg.github.io/sci-components/
MIT License
25 stars 7 forks source link

Focus state appearing on Icon Buttons when clicked on #482

Closed clarsen-czi closed 10 months ago

clarsen-czi commented 1 year ago

Background

When Icon Buttons are clicked on their focus state is triggered. This state should only appear when they are navigated to using keyboards, not clicked on with mice. This has been noticed in both CellxGene and CZ ID (see examples below)


Examples

CZ ID:

Image

CellxGene:

Image

masoudmanson commented 10 months ago

Hey @cathystoli, this issue has already been resolved. Just tagging @clarsen-czi to double-check the styles for confirmation.

clarsen-czi commented 10 months ago

@masoudmanson can you set up a chromatic so I can check the styling? Thanks!

masoudmanson commented 10 months ago

@clarsen-czi You can check it here Thank you 😊

clarsen-czi commented 10 months ago

@masoudmanson Thanks for the link! Everything looks great to me, so I say let's close this one out.

masoudmanson commented 10 months ago

@clarsen-czi Thanks for confirming the styles. I'll close the issue.