Link component underline only applies on last line

chanzuckerberg / sci-components

2021 Science Design System Component Library

https://chanzuckerberg.github.io/sci-components/

MIT License

25 stars 7 forks source link

Link component underline only applies on last line #879

Closed crispipear closed 3 weeks ago

crispipear commented 1 month ago

Describe the bug Link component underline only applies on last line

To Reproduce Steps to reproduce the behavior:

Create a Link component
Use longer string for the text wrapped by Link

Expected behavior The underline should appear on every line

Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS] macOS Ventura 13.3.1
Browser [e.g. chrome, safari] firefox 125.0.3
Version [e.g. 22]

masoudmanson commented 4 weeks ago

Hi @crispipear, Thanks for reporting the bug. I’ve created a fix for the Link component, and it will be published once we get approval from the design team.

Here is the PR: #880

masoudmanson commented 3 weeks ago

10/23 Release

:computer: Coded Library (@czi-sds/components@21.6.1)

:gift: New Features:

Added makeSdsSemanticAppTheme style util

:bug: Bug Fixes:

Fixed an issue where the underline for the Link component was applied only to the last line of text.