chanzuckerberg / shasta

[MOVED] Moved to paoloshasta/shasta. De novo assembly from Oxford Nanopore reads
Other
272 stars 59 forks source link

Added PeakFinder and integrated into Assembler #165

Closed rlorigro closed 4 years ago

rlorigro commented 4 years ago

This adds a method for dynamically selecting a Marker.minCoverage cutoff, using the distribution of coverages from the marker disjoint set object during runtime.

So far it passes all test cases I could generate, but I am going to spend a bit more time evaluating the no-peak cases, so it shouldn't be merged until then.

paoloczi commented 4 years ago

Getting close! I you just remove those using I will merge it, then I will add an explanation in the description of --MarkerGraph.minCoverage in the help message and the documentation, and expand the error message. This is a nice piece of work that simplifies using Shasta, particularly at low coverage.