search

chanzuckerberg / shasta

[MOVED] Moved to paoloshasta/shasta. De novo assembly from Oxford Nanopore reads
Other
272 stars 59 forks source link

Make data members of the Reads class, private. #176

Closed bagashe closed 4 years ago

bagashe commented 4 years ago

LongBaseSequences::operator[] needs a const overload to cleanup dependent code. There're a couple different ways to accomplish that. This one feels the cleanest - I am open to be convinced otherwise.

While tightening the const screws, I had to do the modifications in span.hpp as well.

Test Plan

  1. Ran an E-Coli assembly.
  2. Explored said assembly using the HTTP server.