chanzuckerberg / shasta

[MOVED] Moved to paoloshasta/shasta. De novo assembly from Oxford Nanopore reads
Other
270 stars 57 forks source link

Invalid option in Nanopore-UL-Jun2020 and Nanopore-Jun2020 #290

Closed LYC-vio closed 2 years ago

LYC-vio commented 2 years ago

When running

./shasta-Linux-0.10.0 --command listConfiguration --config Nanopore-Jun2020

or

./shasta-Linux-0.10.0 --command listConfiguration --config Nanopore-UL-Jun2020

Shasta returns:

Invalid option: unrecognised option 'MarkerGraph.refineThreshold'
paoloczi commented 2 years ago

Yes, we generally don't guarantee that all assembly configurations continue to work with all Shasta versions. That options has since been removed. This was announced in the release notes for Shasta 0.9.0 (in the section on deprecated features).

Depending on your situation, you have a few options:

But you have a valid point that we should not have built-in configurations that don't work. For future releases I will make sure to remove any built-in assembly configurations that are no longer functional. However the shasta/conf directory wil continue to contain older assembly configurations that are no longer supported, for completeness and for reference.

Please let me know if I can help better regarding the selection of an assembly configuration appropriate for your situation.

LYC-vio commented 2 years ago

Thank you very much for your quick reply! I'll switch to Nanopore-UL-Dec2019 then.

Thanks again!

paoloczi commented 2 years ago

I am reopening this as a reminder that we need to add a test to check that all built-in assembly configurations are functional, and remove the ones that are not.

Thank you for bringing this up.

paoloczi commented 2 years ago

In commit 7f824e1b91125bd89245a7de342d6559fc418ced I added shasta/scripts/CheckConfigurations.py which checks that all built-in configuration work (two of them don't and will removed in a subsequent commit). This script will be run every time before making a new release.