chanzuckerberg / single-cell-data-portal

The data portal supporting the submission, exploration, and management of projects and datasets to cellxgene.
MIT License
64 stars 14 forks source link

Add WMG API functional tests #1962

Closed atolopko-czi closed 2 years ago

atolopko-czi commented 2 years ago

The functional tests should be able to identify

  1. Compatibility regressions for snapshot data artifacts that might be introduced by the backend API layer
  2. Performance regressions in either a) the backend implementation of TileDB queries, or 2) the WMG cube, due to schema changes or data contents (overall size, or change in data characteristics).

Acceptance Criteria:

Note: tests do not need to verify correctness of returned data. They need only assert the non-empty results are being returned with performance meeting SLOs.

MDunitz commented 2 years ago

I think that 250 ms for the common case is out of reach for our current architecture. Currently (with the larger instance) we have a response time a little under 1.5 seconds

atolopko-czi commented 2 years ago

I think that 250 ms for the common case is out of reach for our current architecture. Currently (with the larger instance) we have a response time a little under 1.5 seconds

So that's the full request/response time (round trip) for the client, right? Do we know how this breaks down between TileDB query time and network I/O?