Dataset ingestion failure notifications should @sc-oncall-eng in #single-cell-ops

chanzuckerberg / single-cell-data-portal

The data portal supporting the submission, exploration, and management of projects and datasets to cellxgene.

MIT License

58 stars 12 forks source link

Dataset ingestion failure notifications should @sc-oncall-eng in #single-cell-ops #2289

Closed metakuni closed 1 year ago

metakuni commented 2 years ago

When dataset ingestion failures occur, the Slack notification message posted to #single-cell-ops should include @sc-oncall-eng so that the on-call engineers are explicitly pinged.

See:

https://github.com/chanzuckerberg/single-cell-data-portal/blob/main/backend/corpora/dataset_processing/slack.py#L10

brianraymor commented 2 years ago

@metakuni - how does this differ from All ingestion failures MUST be reported to #single-cell-ops?

metakuni commented 2 years ago

@metakuni - how does this differ from All ingestion failures MUST be reported to #single-cell-ops?

This issue was to specifically to add the @sc-oncall-eng in the Slack notification so that the on-call engineer would be explicitly pinged on Slack. It's a trivial one-line change.