search

chanzuckerberg / single-cell-data-portal

The data portal supporting the submission, exploration, and management of projects and datasets to cellxgene.
MIT License
63 stars 12 forks source link

scExpression Prod QA - Firefox filtering funkiness #2315

Closed signechambers1 closed 2 years ago

signechambers1 commented 2 years ago

Steps to reproduce:

  1. Firefox
  2. https://cellxgene.dev.single-cell.czi.technology/scExpression
  3. Homo Sapiens, lung, genes: LAP3, CD99, AOC1, CTFR, SARM1
  4. Ethnicity: African American

Notice blue box shows up around ethnicity filter.

tihuan commented 2 years ago

Hmm can we got a screenshot or video/GIF please? I can't repro with Firefox locally 😆 Sorry!

Note that the blue box should show up when you use keyboard tabbing, since that's part of the a11y web standard. But it shouldn't show up if you select ethnicity filter using mouse click!

Thank you!

signechambers1 commented 2 years ago

@tihuan it is happening to me on mouse click. See here https://images.zenhubusercontent.com/228681195/6ad1f4e7-8d13-452f-9a6a-006af6751cf9/firefox_filter_.mov

signechambers1 commented 2 years ago

@hthomas-czi did you have anything additional to add here?

tihuan commented 2 years ago

@tihuan it is happening to me on mouse click. See here https://images.zenhubusercontent.com/228681195/6ad1f4e7-8d13-452f-9a6a-006af6751cf9/firefox_filter_.mov

HMM! This is so weird 😆 I cannot reproduce 🤔

What's your Firefox version? Mine is the latest (v99.0)

demo

@signechambers1

signechambers1 commented 2 years ago

@tihuan ack i thought i was on the latest version but just updated and now i cannot reproduce! so sorry. closing.

tihuan commented 2 years ago

Awesome thank you so much for confirming 🚀 !!