Open Bento007 opened 1 year ago
@tihuan , @seve , @atarashansky : Your opinions?
Ooh yes this looks perfect! Thanks so much for doing this, Trent 🙏
Probably pointing out the obvious, but we'll need to remove the linter in npm and make sure it doesn't break VS Code eslint extension integration
Need
Add the same checks frontend/package.json in the pre-commit file. This will allow the checks to run automatically on commit and save developers some time dealing with linting errors. This is quality of life change to clean code before it is committed.
Approach
We want to run these checks: https://github.com/chanzuckerberg/single-cell-data-portal/blob/c7c1f6e61ff2925007410360ec2f2eb8055c40b8/frontend/package.json#L115 and https://github.com/chanzuckerberg/single-cell-data-portal/blob/c7c1f6e61ff2925007410360ec2f2eb8055c40b8/frontend/package.json#L105 as part of a pre-commit Here is current pre-commit files. This is what the change might looks like.
Definition of Done