chanzuckerberg / single-cell-data-portal

The data portal supporting the submission, exploration, and management of projects and datasets to cellxgene.
MIT License
63 stars 12 forks source link

WMG-v2 bug: CSV download shows tissue name instead of celltype name #5108

Closed signechambers1 closed 1 year ago

signechambers1 commented 1 year ago

Steps to reproduce:

  1. In staging: https://cellxgene.staging.single-cell.czi.technology/wmg-v2
  2. Add JUN, JUNB,JUND
  3. Download CSV
  4. Notice tissue column = cell type column

Cell type column should show celltype name.

ashin-czi commented 1 year ago

@signechambers1

What should the behavior be when tissues aren't expanded for the CSV output?

Currently: image.png

Should it instead be something like this? image.png

When tissue is expanded: image.png

Note the aggregate

tihuan commented 1 year ago

@signechambers1 not sure if Andrew's question above was resolved already 😄 Thank you!

tihuan commented 1 year ago

Following in the repro steps above gets me aggregated tissues in CSV, since we haven't expanded any of the tissue rows. So I think it is expected that there's no cellType row present

However, I think Andrew's suggestion makes sense to replace tissue name in the cellType column with "aggregated"

Concretely:

Without expanded tissues: Screenshot 2023-07-19 at 3.37.24 PM.png

With expanded tissues, thus showing cell types: Screenshot 2023-07-19 at 3.38.02 PM.png

@signechambers1 what do you think?

Thank you!

signechambers1 commented 1 year ago

@tihuan yes! let's make the cell type "aggregate" to reduce confusion as you have shown. Thank you!

tihuan commented 1 year ago

Awesome thanks, @signechambers1 !

Does this look good? If so, I'll start a PR thank you!

Expanded: Screenshot 2023-07-20 at 1.48.07 PM.png

Not expanded: Screenshot 2023-07-20 at 1.48.29 PM.png

signechambers1 commented 1 year ago

@tihuan perfect!

tihuan commented 1 year ago

Ayy sweet ok will send out a PR tomorrow morning! Thanks, Signe!!