search

chanzuckerberg / single-cell-data-portal

The data portal supporting the submission, exploration, and management of projects and datasets to cellxgene.
MIT License
63 stars 12 forks source link

Portal API is yielding 403 for a nonexistent Collection #5684

Closed danieljhegeman closed 11 months ago

danieljhegeman commented 1 year ago

https://api.cellxgene.dev.single-cell.czi.technology/dp/v1/collections/94d7a586-5839-4335-82b6-4352d78f089e

The Portal API appears to be yielding 403 instead of 404 for nonexistent Collection uuids. This should be fixed.

It should be confirmed that this is not happening for Portal Dataset endpoints as well.

danieljhegeman commented 1 year ago

Actually, it's not totally clear to me that we need to change 403->404 in this case. What really matters is that tombstoned Collections, and only tombstoned Collections, return 410.

metakuni commented 1 year ago

Assigning to @danieljhegeman for on-call rotation starting Oct 2. 🙏

metakuni commented 11 months ago

@danieljhegeman in light of your last comment, could you either rewrite the title and description or close this issue? 🙏

danieljhegeman commented 11 months ago

Closing in favor of #5683