Generating shared URL and opening it up in a separate tab/window results in a page crash

chanzuckerberg / single-cell-data-portal

The data portal supporting the submission, exploration, and management of projects and datasets to cellxgene.

MIT License

63 stars 12 forks source link

Generating shared URL and opening it up in a separate tab/window results in a page crash #5775

Closed joyceyan closed 1 year ago

joyceyan commented 1 year ago

For example, I generated this URL: https://cellxgene.cziscience.com/gene-expression?compare=publication&sexes=PATO%3A0000384[…]1L1%2CWNT16&ver=2&cellTypes=B+cell%2CBergmann+glial+cell

And when I opened the link in a new tab, the new tab crashed.

seve commented 1 year ago

The app is failing to find the filtered cell type

seve commented 1 year ago

Cell type was a red herring, looks like the genes are being stripped, and a query is attempted to be made leading to a crash. (genes are required on a query)

seve commented 1 year ago

zenhub or slack broke this URL, there's an encoded [...] in the middle of it

joyceyan commented 1 year ago

Okay yeah I think this isn't a real issue - if you click the link directly in slack it seems fine, it's just when you copy and paste the shortened version with [...] in it it doesn't work

seve commented 1 year ago

there might still be a bug in this, we shouldn't crash on malformed share links. We should just ignore the link

seve commented 1 year ago

P2 though?