chanzuckerberg / single-cell-data-portal

The data portal supporting the submission, exploration, and management of projects and datasets to cellxgene.
MIT License
63 stars 12 forks source link

Fix node permission failure on github actions to unblock all PR's in data-portal #6288

Closed seve closed 10 months ago

seve commented 10 months ago

Currently all PR's on data-portal are failing with some error like:

> cellxgene-data-portal@0.1.0 prettier-check
> npx prettier --check .

glob error [Error: EACCES: permission denied, scandir '/root/.npm/_logs'] {
  errno: -13,
  code: 'EACCES',
  syscall: 'scandir',
  path: '/root/.npm/_logs'
}

npm ERR! Your cache folder contains root-owned files, due to a bug in
npm ERR! previous versions of npm which has since been addressed.
npm ERR! 
npm ERR! To permanently fix this problem, please run:
npm ERR!   sudo chown -R 1001:127 "/root/.npm"

Adding a step for setup-node and/or moving the lint check out of docker could fix this. We're currently 2 major versions behind on usage of setup-node, we should look into the lift required to bump to current

Slack context

seve commented 10 months ago

version 4 also exposes the ability to read from a version file, so we no longer need to manually update the action when we bump our node version!