search

chanzuckerberg / single-cell-explorer

Hosted version of cellxgene
MIT License
11 stars 2 forks source link

Treat singleton values of is_primary_data consistently in the dataset drawer #631

Open signechambers1 opened 1 year ago

signechambers1 commented 1 year ago

Jason pointed out that the dataset draqwer is inconsistently treating singletons for the value is_primary_data. If this value is ALWAYS true or false, then the value should show up in the dataset section in the dataset drawer, example below.

Right now, the value only shows up if it is always true. We would like this value to show up when it is false as well.

Relevant slack thread

cc @signechambers1 for any questions.

Screenshot 2023-07-05 at 7.38.49 PM.png

jahilton commented 6 months ago

@atarashansky I believe this was prematurely closed. The bug described has not been resolved. Please advise if this should reopen or if I can create a new Issue.

atarashansky commented 6 months ago

Hi @jahilton - I thought I had resolved it with this PR. If this is still a bug, I can reopen this issue.

jahilton commented 6 months ago

Here is one example Dataset where all cells are is_primary_data:False. Please let me know when I can review a fix in staging/dev

niknak33 commented 3 months ago

@seve if it was addressed, and reach out to Jason.