search

chanzuckerberg / single-cell-explorer

Hosted version of cellxgene
MIT License
11 stars 2 forks source link

Enable rendering full resolution image #800

Closed tihuan closed 7 months ago

tihuan commented 7 months ago

Context: The MVP only renders ~low-res~ (UPDATE (2/29): no low-res support) and high-res, this ticket will enable rendering full res image in the spatial mode

DoD:

  1. A user is now able to select full res in embedding mode option
  2. Export PNG still works
  3. Add e2e tests
tihuan commented 7 months ago

Hey team! Please add your planning poker estimate with Zenhub @kaloster @seve

tihuan commented 7 months ago

My estimate assumes that tweaking the scaleFactor won't take more than a few hours, or maybe scaleFactor is not even needed for full res?

brianraymor commented 7 months ago

or maybe scaleFactor is not even needed for full res?

There is no scalefactor for fullres, because the embedding is already fullres.

This was documented in the implementation notes that I shared with you on slack:

If uns['spatial'][library_id]['images']['fullres'] is present, then CELLxGENE Explorer MUST add a selector item named "spatial_FullRes_Map" and MUST NOT scale the full resolution embedding.

brianraymor commented 7 months ago

The MVP only renders low-res and high-res, this ticket will enable rendering full res image in the spatial mode

FYI - The schema does not support lowres, only highres (required) and fullres (optional).

tihuan commented 7 months ago

Ah thanks for confirming, Brian! Then hopefully adding full res support will be a lot less work than estimated 🤞

And appreciate you pointing out the low-res stuff. I'll update the ticket accordingly! (Sorry I haven't checked the schema yet 😆)

tihuan commented 7 months ago

Closing, since we're implementing deep zooming