search

chanzuckerberg / single-cell-explorer

Hosted version of cellxgene
MIT License
11 stars 2 forks source link

[PROD] Lasso is broken #843

Closed tihuan closed 6 months ago

tihuan commented 7 months ago

Context:

@seve Lasso isn’t resetting on failure to close the lasso

https://chanzuckerbergteam.slack.com/archives/C06FM5ZQE3Y/p1710966938965819

Repro:

  1. Visit https://cellxgene.dev.single-cell.czi.technology/d/pbmc3k.cxg/?spatial=false
  2. Use lasso and create an invalid lasso
  3. Expect the invalid lasso to go away, but it's stuck and we cannot use lasso anymore

Private Zenhub Video

DoD:

  1. Fix the bug
  2. Add e2e test
tihuan commented 6 months ago

Moving this back to WIP to make sure we have e2e test. Thanks, @seve !