feat(side by side embedding): complex embedding feature parity

[seve]

This issue captures the more complex features that are needed in the side panel in order to match the feature set found in the main graph.

• [ ] Lasso in panel
  • [ ] Need to create a separate reducer for the smaller lasso (this is to ensure that lassos aren't cancelled across the two)|
  • [ ] Fix lasso where the two lasso layers overlap
  • [ ] Lasso should reset when changing embeddings (legacy handling)
• [ ] Camera
  • [ ] When starting a camera action in one graph, lock the mouse actions to the origin graph

[seve]

@niknak33 are we okay to reset zoom and/or lasso state if we swap the embeddings in the main and panel views?

[niknak33]

That's fine Seve - Thank you.

On Fri, May 10, 2024 at 12:45 PM Severiano Badajoz @.***> wrote:

@niknak33 https://github.com/niknak33 are we okay to reset zoom and/or lasso state if we swap the embeddings in the main and panel views?

— Reply to this email directly, view it on GitHub https://github.com/chanzuckerberg/single-cell-explorer/issues/925#issuecomment-2105178352, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2S5ZBF3EGFGX24ZUL6LR6LZBUPVFAVCNFSM6AAAAABHRDDGBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVGE3TQMZVGI . You are receiving this because you were mentioned.Message ID: @.***>

[tihuan]

For resize - currently we're attaching a "resize" event listener on window, which is inefficient (since the canvas element doesn't necessary resize when the window resizes) and won't work well that now the Graph component is used in both the main and side panels.

Perhaps we should use ResizeObserver to observe Graph.props.viewportRef to capture the resize event instead?

[tihuan]

@seve I'll unassign myself from this one since I didn't get to work on it this week and I'll be out for a week 🙏

Happy to pick it back up if it's not worked on yet by the time I get back! Thank you!

[tihuan]

implemented in the feature branch already