search

chanzuckerberg / sorbet-rails

A set of tools to make the Sorbet typechecker work with Ruby on Rails seamlessly.
MIT License
638 stars 84 forks source link

fix workflows for CI and gem publishing #484

Closed ashkulz closed 2 years ago

ashkulz commented 2 years ago

Also made a change so that the CI always runs on Mondays, so that you get to know sooner when there's a breaking change due to dependency updates rather than a few months later when someone makes a PR and you don't know what happened.

ashkulz commented 2 years ago

It gets generated automatically by srb rbi.

ghiculescu commented 2 years ago

Ohhh I thought it was the file from this gem. My bad.

codecov[bot] commented 2 years ago

Codecov Report

Merging #484 (19f6bdd) into master (70782c2) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
- Coverage   97.64%   97.64%   -0.01%     
==========================================
  Files         115      115              
  Lines        2926     2924       -2     
==========================================
- Hits         2857     2855       -2     
  Misses         69       69
Impacted Files Coverage Δ
spec/sorbet_spec.rb 100.00% <100.00%> (ø)
spec/support/v6.1/sorbet_test_cases.rb 100.00% <0.00%> (ø)
...ort/v6.1/app/mailers/hogwarts_acceptance_mailer.rb 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 70782c2...19f6bdd. Read the comment docs.

ghiculescu commented 2 years ago

Thanks!!