chaobian / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

Remove variables for prefix/suffix #135

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
There should be a platform-neutral way to specify the product prefix and 
suffix -- something like: PRODUCT_PREFIX, PRODUCT_SUFFIX.
On Mac, this would translate to: EXECUTABLE_PREFIX, EXECUTABLE_EXTENSION

The documentation talks about EXECUTABLE_PREFIX/EXECUTABLE_SUFFIX but 
that doesn't work for libs.

Original issue reported on code.google.com by nirnimesh@chromium.org on 12 Jan 2010 at 9:57

GoogleCodeExporter commented 9 years ago

Original comment by bradnelson@google.com on 13 Jan 2010 at 6:55

GoogleCodeExporter commented 9 years ago
I would prefer to remove all this prefix/suffix stuff and just require the gyp 
file to hardcode the product name when we care about the specific filename we 
produce.  Mark, what do you think?

Original comment by evan@chromium.org on 26 May 2011 at 8:24

GoogleCodeExporter commented 9 years ago
Seeing how people have (ab)used the prefix thing inclines me to agree.

Original comment by mark@chromium.org on 26 May 2011 at 8:46

GoogleCodeExporter commented 9 years ago
In the Chrome tree, it appears we don't use pre/suffix very often.

$ git grep "':" -- '*.gyp*' | grep -o "'[^ ]*':" | egrep -i 'prefix|suffix' | 
sort | uniq -c | sort -n
      1 'product_prefix':
      2 'GCC_PRECOMPILE_PREFIX_HEADER':
      3 'plugin_prefix':

Original comment by evan@chromium.org on 26 May 2011 at 10:13

GoogleCodeExporter commented 9 years ago

Original comment by evan@chromium.org on 26 May 2011 at 10:14

GoogleCodeExporter commented 9 years ago
Not going to get to this before I get on leave.

Original comment by evan@chromium.org on 20 Sep 2011 at 6:56

GoogleCodeExporter commented 9 years ago

Original comment by evan@chromium.org on 20 Sep 2011 at 6:56

GoogleCodeExporter commented 9 years ago

Original comment by evan@chromium.org on 20 Sep 2011 at 6:57