Closed mertcandav closed 3 years ago
@mertcandav hi, first of all thank you so much for this great pull request! I'm the owner of this project. There are two major problems in this PR:
rewrite
branch. I can explain the motivations for this branch in a separate thread. But this PR of yours, will cause a lot of merge conflicts and modifying many lines that will be removed in rewrite
branch. So it will cause some problems.Also I would like to ask that if you created this huge diff automatically using a linting tool or manually? If it's automatically generated diff then what tool did you use and how did you do it?
If you are unable to see the CI log then I can invite you to the GitHub organization. Also I would like to invite you to our Discord server to discuss the changes.
Description
This PR combines the code style of the whole project in one style. It improves readability and supports developers using vertical monitors and the universal line width limit, assuming a maximum line width of 80.
Types of changes
Checklist