search

chaos-lang / chaos

The Chaos Programming Language
https://chaos-lang.org
GNU General Public License v3.0
281 stars 17 forks source link

Linting requirements.sh #91

Closed naltun closed 3 years ago

naltun commented 3 years ago

Describe the performance issue

requirements.sh has some visible linting issues:

1) There are unused variables 2) The Bash code is not optimized

Add the example Chaos code that suffers from performance drawbacks

The most obvious update that needs addressing is the use of ! -z instead of the builtin -n flag. These are the same, and we should always go with the simpler option.

naltun commented 3 years ago

I will review the file again before closing this issue out.

naltun commented 3 years ago

I have reviewed requirements.sh and we are all good. Closing.