search

chaos-mesh / chaosd

A Chaos Engineering toolkit.
Apache License 2.0
136 stars 63 forks source link

download memStress and stress-ng according to the architecture #198

Closed YangKeao closed 2 years ago

YangKeao commented 2 years ago

Signed-off-by: YangKeao yangkeao@chunibyo.icu

Close https://github.com/chaos-mesh/chaosd/issues/196

ti-chi-bot commented 2 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
FingerLeader commented 2 years ago

Should I change the target arch of memStress in the feature? So that both stress-ng and memStress can use the same tag.

YangKeao commented 2 years ago

Should I change the target arch of memStress in the feature? So that both stress-ng and memStress can use the same tag.

Good! But you'll also need to modify the chaos mesh.

Or should I modify the target arch of stress-ng? (though they are the same with arch in matrix.)

FingerLeader commented 2 years ago

Should I change the target arch of memStress in the feature? So that both stress-ng and memStress can use the same tag.

Good! But you'll also need to modify the chaos mesh.

Or should I modify the target arch of stress-ng? (though they are the same with arch in matrix.)

Considering chaos mesh, maybe change the arch tag of stress-ng is better, cause memStress has the tag with other tools.

STRRL commented 2 years ago

HI @YangKeao @FingerLeader @Andrewmatilde, could we merge this PR now?

YangKeao commented 2 years ago

/hold

YangKeao commented 2 years ago

HI @YangKeao @FingerLeader @Andrewmatilde, could we merge this PR now?

I'll change the architecture tag of the stress-ng, so don't merge.

YangKeao commented 2 years ago

/unhold

cwen0 commented 2 years ago

/merge

ti-chi-bot commented 2 years ago

This pull request has been accepted and is ready to merge.

Commit hash: 0a275930b3a6027961acd527859bb2cddf07e08c