Store iptables when creating network attack

chaos-mesh / chaosd

A Chaos Engineering toolkit.

Apache License 2.0

136 stars 63 forks source link

Store iptables when creating network attack #215

Closed FingerLeader closed 2 years ago

FingerLeader commented 2 years ago

Signed-off-by: root root@localhost.localdomain Close #213

ti-chi-bot commented 2 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

cwen0 commented 2 years ago

@FingerLeader I test this pr on my environment, I found the network delay still cancel when I applied a partition action.

./bin/chaosd version
Chaosd Version: version.Info{GitVersion:"fix-partition-g83eccfacc55fe7", GitCommit:"83eccfacc55fe7a29c102df7cb05daa2ea1ac00f", BuildDate:"2022-09-13T15:03:27Z", GoVersion:"go1.19", Compiler:"gc", Platform:"linux/amd64"} 
./bin/chaosd attack network delay -i 39.156.66.10 -d eth0 -l 200ms
./bin/chaosd attack network partition -i 140.205.220.96 -d eth0

FingerLeader commented 2 years ago

I found the network delay still cancel when I applied a partition action.
./bin/chaosd version

I test it again and find it works. Maybe you can delete ./bin/chaosd.dat and try again.

cwen0 commented 2 years ago

I found the network delay still cancel when I applied a partition action.
./bin/chaosd version
I test it again and find it works. Maybe you can delete ./bin/chaosd.dat and try again.

OK, I will test it again

FingerLeader commented 2 years ago

@cwen0 I have updated, please have a try again.

cwen0 commented 2 years ago

/merge

ti-chi-bot commented 2 years ago

@cwen0: /merge in this pull request requires 2 approval(s).

In response to [this](https://github.com/chaos-mesh/chaosd/pull/215#issuecomment-1247030918): >/merge Instructions for interacting with me using PR comments are available [here](https://prow.tidb.io/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.