Fix issue about disk attack cannot work well in chaos-mesh:physical machine chaos

chaos-mesh / chaosd

A Chaos Engineering toolkit.

Apache License 2.0

136 stars 63 forks source link

Fix issue about disk attack cannot work well in chaos-mesh:physical machine chaos #236

Closed Andrewmatilde closed 1 year ago

Andrewmatilde commented 1 year ago

Add a command pool to orgnize sub commands. Make disk chaos in server side runs asynchronously.

ti-chi-bot commented 1 year ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

Andrewmatilde commented 1 year ago

PTAL @cwen0 .

Andrewmatilde commented 1 year ago

/merge

ti-chi-bot commented 1 year ago

@Andrewmatilde: /merge in this pull request requires 2 approval(s).

In response to [this](https://github.com/chaos-mesh/chaosd/pull/236#issuecomment-1422252324): >/merge Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.

Andrewmatilde commented 1 year ago

/merge

ti-chi-bot commented 1 year ago

This pull request has been accepted and is ready to merge.

Commit hash: 43c47119a4e479f73ef05c007058148238de630f