search

chaos-polymtl / lethe

Repository for the open-source lethe CFD/DEM/CFD-DEM project
https://chaos-polymtl.github.io/lethe/index.html
Apache License 2.0
280 stars 60 forks source link

Rotating drum with post-processing example is now useless #1003

Closed blaisb closed 1 month ago

blaisb commented 10 months ago

We have an example (this one https://lethe-cfd.github.io/lethe/documentation/examples/dem/rotating-drum-with-postprocessing/rotating-drum-with-postprocessing.html) which is literally useless since it only adds a single line and does not add any new interpretation or animations. It should be deprecated and removed

nick0413 commented 2 months ago

On this issue, i have been trying to run the small rotating drum example but i get the following error.

An error occurred in line <700> of file </home/nick0413/Software/lethe/git/source/core/utilities.cc> in function int get_max_number_of_boundary_conditions(const string&) The violated condition was: max_number_of_boundary_conditions >= 0 Additional information: Your parameter file does not contain any indication for the number of boundary conditions for any physics supported by Lethe. Since November 2023, Lethe requires that a "boundary conditions" subsection is present with at least "number=0"

Im thinking the entire example is outdated

blaisb commented 2 months ago

Have you updated to the latest version of lethe? The parameter file for this example works fine with the current version ( I am running the example right now on my desktop computer)

nick0413 commented 2 months ago

Oh, then it must be a problem with my install then. I followed the install guide for WSL last Monday, so I figured it is the updated version

On Sun, Sep 8, 2024, 8:57 AM Bruno Blais @.***> wrote:

Have you updated to the latest version of lethe? The parameter file for this example works fine with the current version ( I am running the example right now on my desktop computer)

— Reply to this email directly, view it on GitHub https://github.com/chaos-polymtl/lethe/issues/1003#issuecomment-2336696379, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQMQUVS3F3GJY4BI3ESGS63ZVRJWDAVCNFSM6AAAAABN2TICRSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZWGY4TMMZXHE . You are receiving this because you commented.Message ID: @.***>

blaisb commented 2 months ago

Well yes, the version you installed on WSL from last Monday should indeed be the latest version (at least nothing major should have changed since then).

The error you are specifying occurs at this line: https://github.com/chaos-polymtl/lethe/blob/master/examples/dem/3d-rotating-drum-postprocessing/rotating-drum-with-postprocessing.prm#L90

This is because at one point we did not specify the number of boundary conditions.

If that line is indeed correct, it would appear that something is being "read" differently between your prm files due to it running in WSL.

Generally, which is not such a good thing, but this boundary error is sometimes thrown when there is an illegal character in the file since it is always the first "command" that is run in the parameter files. If you are using the version of the parameter file from the repo and you get this error, please post again here and I will try to tifgure this out with you :)