chaos-polymtl / lethe

Repository for the open-source lethe CFD/DEM/CFD-DEM project

https://chaos-polymtl.github.io/lethe/index.html

Apache License 2.0

278 stars 59 forks source link

Add fields check to physical property models #1065

Closed AmishgaAlphonius closed 7 months ago

AmishgaAlphonius commented 8 months ago

Description of the problem

Some physical and interface property models require certain fields to compute property values and partial derivatives. When these fields were not defined a not so debug-friendly message was printed out.

Description of the solution

To help the debugging process, if an error were to occur, assertions were added to the property models in functions where the fields were required.

How Has This Been Tested?

By commenting lines in unit tests and code, the throw of the exception was verified in DEBUG mode.

Comments

Doxygen descriptions were also added to specific_heat_model.h.

blaisb commented 8 months ago

@AmishgaAlphonius if you rebase I can then merge. I think this is a good PR

AmishgaAlphonius commented 8 months ago

@AmishgaAlphonius if you rebase I can then merge. I think this is a good PR

@blaisb done ! :)