Closed yashuuzi closed 3 months ago
@yashuuzi Tell us when you are ready for a second review :)
Thanks Bruno! I'm now thinking about the expression about cell size, and average volume size. I understand them, but I'm still looking for good expression. Maybe I'll finish it and ask you to Re-request until today! :)
@yashuuzi I think there was an issue in your rebase because there are so many files that should not have been modified by your PR. I will try to fix it up.
Update: I fixed it
Thanks everyone for reviewing! I modified all of the parts you suggested.
The problem is that my parameters are not optimized and the time CFD_DEM simulation took is more than 8 days, which is too long. I'm now trying to find the optimized parameters
@yashuuzi can you fix the compilation of the documentation warning issue :)
@OGaboriault I just need your approval before i can merge that branch
Description
I created the example of gas-solid-spouted-cylinder-bed, and write a document for that. I added this at /lethe/example/unresolved-cfd-dem/gas-solid-spouted-cylinder-bed/ and /lethe/doc/source/example/unresolved-cfd-dem/gas-solid-spouted-cylinder-bed
WIP