search

chaos-polymtl / lethe

Repository for the open-source lethe CFD/DEM/CFD-DEM project
https://chaos-polymtl.github.io/lethe/index.html
GNU Lesser General Public License v2.1
267 stars 59 forks source link

Create a example of gas-solid-spouted-cylinder-bed #1101

Closed yashuuzi closed 3 months ago

yashuuzi commented 3 months ago

Description

I created the example of gas-solid-spouted-cylinder-bed, and write a document for that. I added this at /lethe/example/unresolved-cfd-dem/gas-solid-spouted-cylinder-bed/ and /lethe/doc/source/example/unresolved-cfd-dem/gas-solid-spouted-cylinder-bed

WIP

blaisb commented 3 months ago

@yashuuzi Tell us when you are ready for a second review :)

yashuuzi commented 3 months ago

Thanks Bruno! I'm now thinking about the expression about cell size, and average volume size. I understand them, but I'm still looking for good expression. Maybe I'll finish it and ask you to Re-request until today! :)

blaisb commented 3 months ago

@yashuuzi I think there was an issue in your rebase because there are so many files that should not have been modified by your PR. I will try to fix it up.

Update: I fixed it

yashuuzi commented 3 months ago

Thanks everyone for reviewing! I modified all of the parts you suggested.

The problem is that my parameters are not optimized and the time CFD_DEM simulation took is more than 8 days, which is too long. I'm now trying to find the optimized parameters

blaisb commented 3 months ago

@yashuuzi can you fix the compilation of the documentation warning issue :)

blaisb commented 3 months ago

@OGaboriault I just need your approval before i can merge that branch