chaos-polymtl / lethe

Repository for the open-source lethe CFD/DEM/CFD-DEM project

https://chaos-polymtl.github.io/lethe/index.html

GNU Lesser General Public License v2.1

267 stars 59 forks source link

Dem fixing tangential overlap #1107

Closed OGaboriault closed 3 months ago

OGaboriault commented 3 months ago

Description of the problem

The normal overlap and tangential overlap vectors needs to be perpendicular through out a collision, which is not the case in the current implementation.

Description of the solution

We subtract the projection of the tangential overlap on the normal vector from the tangential overlap at every time step.
This is not done for particle-wall contacts, since the normal vector remains the same through out a collision with a flat wall (which is the only type of wall currently implemented).

How Has This Been Tested?

With the application test. Some results have slightly changed

blaisb commented 3 months ago

Why do you have so many changed files that are unrelated to DEM? All tests that do not include particles should not be changed. Please be careful when adding files and monitor which files you are adding. I think this is an episode of git commit -a....