chaos-polymtl / lethe

Repository for the open-source lethe CFD/DEM/CFD-DEM project

https://chaos-polymtl.github.io/lethe/index.html

GNU Lesser General Public License v2.1

267 stars 59 forks source link

Update update-golden for the serial output #1108

Closed OGaboriault closed 3 months ago

OGaboriault commented 3 months ago

Description of the problem

Update golden wasn't working for tests where the mpirun=X was not specified. Copied output files were then named with a ".serial.output" and not just with a ".output" at the end.

How Has This Been Tested?

This code has been used on [PR#1107]https://github.com/chaos-polymtl/lethe/pull/1107. It is not perfect, but it gets the job done way faster then by copying the files manually.
[ ] File A

Comments

This implementation doesn't work with ".disabled" test or with ".with_dealii.geq.9.X.output" files. Like I said, it gets the job done, but it's not perfect.
@paulapatience if you want to change the code, be my guest! :)

blaisb commented 3 months ago

I am fine with this, but I will let @paulapatience take a look first :)

paulapatience commented 3 months ago

Looks good. If you don't squash the commits, maybe say something like "Glob for potential golden files" in the second commit's message.