chaos-polymtl / lethe

Repository for the open-source lethe CFD/DEM/CFD-DEM project
https://chaos-polymtl.github.io/lethe/index.html
GNU Lesser General Public License v2.1
267 stars 59 forks source link

Robin/Neumann BC parameters were not space dependent #1128

Closed voferreira closed 3 months ago

voferreira commented 3 months ago

Description of the problem

Description of the solution

How Has This Been Tested?

Documentation

Comments

voferreira commented 3 months ago

@blaisb Thanks! I thought set_time was called on update_boundary_conditions, but the if in the integration was preventing it from being called. This is fixed now. Plus I have placed the assertion for the emissivity at the right place, I believe. I also added a transient test for heat_flux = 10ty.

blaisb commented 3 months ago

I'll let @mivaia take a look at it and then if he's ok with it I'll merge