chaos-polymtl / lethe

Repository for the open-source lethe CFD/DEM/CFD-DEM project

https://chaos-polymtl.github.io/lethe/index.html

GNU Lesser General Public License v2.1

267 stars 59 forks source link

Solid objects did not trigger a contact detection step when they were moved #1136

Closed blaisb closed 3 months ago

blaisb commented 3 months ago

Description of the problem

Moving solid objects did not trigger a contaction step when they moved. This was problematic since if the particles were static, the solid objects could waltz through them if no contact detection were triggered on the particle side.

Description of the solution

Trigger a contact detection step when the solid object is mapped again.

How Has This Been Tested?

Bunny example without load balancing works fine now.

Comments

This may have a small negative impact on performance. This will improve when we refactor the contact detection mechanism in the code to make it cleaner and more logical.

Should close issue #1132

blaisb commented 3 months ago

@acdaigneault I deleted the garbage print and merged the two ifs, should be ready for final review