chaos-polymtl / lethe

Repository for the open-source lethe CFD/DEM/CFD-DEM project
https://chaos-polymtl.github.io/lethe/index.html
GNU Lesser General Public License v2.1
257 stars 54 forks source link

Create a postprocessing function for cfd-dem #1147

Closed yashuuzi closed 1 month ago

yashuuzi commented 1 month ago

Description of the problem

Description of the solution

How Has This Been Tested?

Documentation

voferreira commented 1 month ago

As this introduces a parameter, this parameter needs to be added to the documentation. Additionally, since this feature is used to have an assessment of the accuracy of the void fraction scheme, I feel it would be very useful to have application tests using it. This way, if we try to improve something on the current schemes, we can make sure it gives the same result.

blaisb commented 1 month ago

@yashuuzi can you re-indent the code?

yashuuzi commented 1 month ago

Thank you so much for reviewing! I'll fix them and let you know when I've done

yashuuzi commented 1 month ago

I'm ready for second review! Actually I could't come up with good name of parameter which is better than "volume phases", but I think it's understandable.

voferreira commented 1 month ago

Please, don't forget to rebase. Your branch is 20 commits behind master.

blaisb commented 1 month ago

@yashuuzi Is this ready for a final review / merge? Try to finish this as a priority :)

yashuuzi commented 1 month ago

I finished modifying and ready to final review!