chaos-polymtl / lethe

Repository for the open-source lethe CFD/DEM/CFD-DEM project

https://chaos-polymtl.github.io/lethe/index.html

GNU Lesser General Public License v2.1

257 stars 54 forks source link

Sort operation in DCDD implementation in VOF and Tracer #1155

Closed voferreira closed 1 month ago

voferreira commented 1 month ago

Description of the problem

DCDD calculation was done using test function multiplied by the right and function multiplied by the left in VOF and Tracer applications

Description of the solution

Fixed the indices
Plus, the boolean attribute that activated DCDD (previously used for tests) was deprecated

How Has This Been Tested?

All tests pass

Documentation

No need

Future changes

This one solves the issue for DCDD

Comments

Maybe this operation can be inverted in other places in the code. I will try to keep an eye on it and change as I go.

blaisb commented 1 month ago

@voferreira some warnings and tests to fix I think

voferreira commented 1 month ago

I fixed it and didn't push. It is an extra curly bracke in the end of the Assembler :x

voferreira commented 1 month ago

@blaisb All clear

blaisb commented 1 month ago

@blaisb All clear

Cool to know that none of the test results changed though. Means this was not making a difference at all.