chaos-polymtl / lethe

Repository for the open-source lethe CFD/DEM/CFD-DEM project

https://chaos-polymtl.github.io/lethe/index.html

Apache License 2.0

271 stars 60 forks source link

Add refinement at frequency tests #1163

Closed oguevremont closed 4 months ago

oguevremont commented 4 months ago

Description of the problem

The "refinement_at_frequency" member is set by setting the frequency to 0.
There was not test for this.

Description of the solution

2 tests were added.

How Has This Been Tested?

[application_tests/lethe-fluid/refinement_at_frequency_on] With frequency set to 1
[application_tests/lethe-fluid/refinement_at_frequency_on] With frequency set to 0

Comments

I would have preferred to have a true unit test for this instead of an application test, because with these changes the other physics are not tested. I'll keep looking for a way to test the parser itself.

OGaboriault commented 4 months ago

Regarding the test instead of an application test, what is the problem?

oguevremont commented 4 months ago

Regarding the test instead of an application test, what is the problem?

The problem is that the boolean variable "refinement_at_frequency" is set in the parsing function when "frequency" is set to 0, so we cannot test that it is properly set unless we do the parsing.

OGaboriault commented 4 months ago

Regarding the test instead of an application test, what is the problem?

The problem is that the boolean variable "refinement_at_frequency" is set in the parsing function when "frequency" is set to 0, so we cannot test that it is properly set unless we do the parsing.

You can create a fake prm object in a test a think, that could solve your problem (but I'm not sure). But like Bruno said it is okay for now. :)