Dem force chain ghost - Githubissues

chaos-polymtl / lethe

Repository for the open-source lethe CFD/DEM/CFD-DEM project

https://chaos-polymtl.github.io/lethe/index.html

GNU Lesser General Public License v2.1

257 stars 54 forks source link

Dem force chain ghost #1172

Closed cleodeletre closed 3 weeks ago

cleodeletre commented 1 month ago

Description

Finalization of the force chains feature.

Ghost particles are implemented in the calculate_force_chains method
PVD output file is added in the write_force_chains method
Documentation is updated in the post-processing.rst part.

Testing

Tested with the rectangular hopper example.

Documentation

Documentation is updated. A new parameter in the post-processing part of parameter files is force chains.

blaisb commented 1 month ago

I added @acdaigneault as reviewer here cause she has a good eye for this kinda stuff

acdaigneault commented 3 weeks ago

Also, for the PR description, next time let the checklists there and all the description in the PR. It helps the reviewers to know that is done and what you know it is not done yet. When Bruno merges the PR, he is the one that copy/paste the first sections for the commit of the whole PR, but everything is kept in the closed PR archive :) Don't hesitate if you have question related to that!

blaisb commented 3 weeks ago

@cleodeletre I think there are still some comments that need to be addressed and also the youtube link to fix. Message me if you need help with the y outube link I will be glad to help you

blaisb commented 3 weeks ago

@cleodeletre Can you resolve the conversations you are done with? I can take a quick look again when you are ready and then merge it.

cleodeletre commented 3 weeks ago

@blaisb All the conversations are resolved. I'm done with the modifications.

blaisb commented 3 weeks ago

Okidoke, I'll assume @OGaboriault was ok with the changes and go ahead and merge ^^!