chaos-polymtl / lethe

Repository for the open-source lethe CFD/DEM/CFD-DEM project
https://chaos-polymtl.github.io/lethe/index.html
GNU Lesser General Public License v2.1
257 stars 54 forks source link

Checkpointing current_file_id for file insertion #1174

Closed OGaboriault closed 3 weeks ago

OGaboriault commented 4 weeks ago

Description

The current_file_id wasn't being checkpointed. This means that the next file being used to insert particles would be the first one after a restart.

Solution

current_file_id is now being checkpointed.

Testing

Havent been tested yet, but I dont think it need to be. Logically, it should work.

Documentation

N/A

Miscellaneous (will be removed when merged)

N/A

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

Pull request related list:

acdaigneault commented 4 weeks ago

You said no need to test it, but did ou make sure it works? Like, you tried a restart? I know it might be a like specific, but I would add a test. If somehow something else broke that feature, will would be a painfull to debug. Failling restarts are hard to debug as we have seen lately. :) but since it's a tinny PR, maybe let's agree on adding a test later

blaisb commented 4 weeks ago

I think I agree with @acdaigneault I would prefer if you could add a test here. Does not have to be complicated, but it will be impossible to verify that this feature still works correctly TBH, we have added a lot of restart tests lately, but we need even more

OGaboriault commented 4 weeks ago

I'll do a test tonight or tomorrow