chaos-polymtl / lethe

Repository for the open-source lethe CFD/DEM/CFD-DEM project
https://chaos-polymtl.github.io/lethe/index.html
GNU Lesser General Public License v2.1
257 stars 54 forks source link

Update installation doc #1183

Closed AmishgaAlphonius closed 1 week ago

AmishgaAlphonius commented 2 weeks ago

Description

This PR follows #1181 and updates documentation related to the installation of Lethe. More specifically, it corrects the version of p4est to be installed to 2.3.6.

Miscellaneous (will be removed when merged)

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

Pull request related list:

AmishgaAlphonius commented 2 weeks ago

I just want to add that the Trilinos version in the current Candi script had change to 14.0, which also require cmake 3.26 if you have an older version. Do you think we could fork candi and modify everything according to our parameters?

I think that's a great idea to make a fork, it would simplify the steps for users that are installing and therefore make it more accessible for them! If @blaisb is fine with it, I could do so. As for the Trilinos version, I was hesistating over it also, but as it is machine-dependent, I preferred not forcing a version, but I could change it for 13 on the fork (or doc), and leave a comment about it.

blaisb commented 1 week ago

I agree with making a fork for candi, it's a good idea. I'm also a maintainer of CANDI so I could also make changes directly into the repository if we want