chaos-polymtl / lethe

Repository for the open-source lethe CFD/DEM/CFD-DEM project
https://chaos-polymtl.github.io/lethe/index.html
Apache License 2.0
271 stars 60 forks source link

Tracer with Sharp IB #1185

Closed oguevremont closed 2 months ago

oguevremont commented 3 months ago

Description

Testing

Documentation

[doc/source/parameters/cfd/physical_properties] The new model has been added in new section where immersed solids models will be added in the future.

Miscellaneous (will be removed when merged)

This PR was done with more generality than needed in preparation of the reactive physics that will be implemented soon.

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

Pull request related list:

blaisb commented 2 months ago

@oguevremont is this ready to review or not ? It seems to be in an intermediary state. If so please remove the ready to review label

oguevremont commented 2 months ago

@oguevremont is this ready to review or not ? It seems to be in an intermediary state. If so please remove the ready to review label

It is not ready yet, I forgot to remove the ready to review label.

blaisb commented 2 months ago

@oguevremont do you have additional things to add or this is ready to merge? If this is ready to merge I'll let you add the label Reviewed and ready to merge and then I'll merge