The entry_string_to_tensor functions were duplicated; they were in utilities.h and parameters.h. In one case it was templated with spacedim and the other not. This PR merges both uses of the same function in utilities.h. Since these are small functions, they were inlined. Hence, they don't have any explicit instantiation.
While doing this, redundant if conditions were noticed in the manifolds.cc, these were replaced by for loops.
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
[x] All in-code documentation related to this PR is up to date (Doxygen format)
[x] Lethe documentation is up to date
[x] The branch is rebased onto master
[x] Code is indented with indent-all and .prm files (examples and tests) with prm-indent
[x] If parameters are modified, the tests and the documentation of examples are up to date
[x] Changelog (CHANGELOG.md) is up to date if the refactor affects the user experience or the codebase
Pull request related list:
[x] No other PR is open related to this refactoring
[x] Labels are applied
[x] There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
[x] If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
[x] If any future works is planed, an issue is opened
[x] The PR description is cleaned and ready for merge
Description
The
entry_string_to_tensorfunctions were duplicated; they were inutilities.handparameters.h. In one case it was templated withspacedimand the other not. This PR merges both uses of the same function inutilities.h. Since these are small functions, they were inlined. Hence, they don't have any explicit instantiation.While doing this, redundant
ifconditions were noticed in themanifolds.cc, these were replaced byforloops.Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: