The NS-VOF assembler was not optimized as the NS assembler. The if conditions on the dof components were added to not compute multiplications that are a priori 0.
Testing
None of the application tests have changed. The computational time gain is about 20% by iteration on the 3D lpbf benchmark case for a simulation of about 300 iterations. I can do it for a complete simulation if you thing it is worth doing it :)
Documentation
No new documentation needed.
Miscellaneous (will be removed when merged)
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
[x] All in-code documentation related to this PR is up to date (Doxygen format)
[x] Lethe documentation is up to date
[x] New feature has unit test(s) (preferred) or application test(s), and restart files are in the generator folder
[x] The branch is rebased onto master
[x] Changelog (CHANGELOG.md) is up to date
[x] Code is indented with indent-all and .prm files (examples and tests) with prm-indent
Pull request related list:
[x] Labels are applied
[x] There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
[x] If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
[x] If the fix is temporary, an issue is opened
[ ] The PR description is cleaned and ready for merge
Description
The NS-VOF assembler was not optimized as the NS assembler. The if conditions on the dof components were added to not compute multiplications that are a priori 0.
Testing
None of the application tests have changed. The computational time gain is about 20% by iteration on the 3D lpbf benchmark case for a simulation of about 300 iterations. I can do it for a complete simulation if you thing it is worth doing it :)
Documentation
No new documentation needed.
Miscellaneous (will be removed when merged)
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: