Encapsulation of the load balancing in DEM and CFD-DEM

[acdaigneault]

Description

The functions related to the load balancing were implemented in the DEM solver and coupling CFD-DEM solver even tho it is not really specific to the solvers. The setup and the routine were duplicated in both solvers, making modifications or maintenances harder. The solution is the implementation the load balancing class with mostly the same functions. The load balancing is also fixed for the CFD-DEM. It was not working since nov. 2022, oops.

Testing

All tests related to the load balacing in DEM are still passing. A new test spouted_bed_load_balancing_generator.prm was added for the unresolved cfd-dem tests. After a quick fix on the master, results were compared and are the same.

Miscellaneous (will be removed when merged)

It is not fully encapsulated (the load_balance() functions are still implemented in the solvers), but it is the cleanest and easier way to do it to this day with the way the code flags some step (load_balancing, checkpoint, etc...) and executes reinititialization and other stuff.

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

• [x] All in-code documentation related to this PR is up to date (Doxygen format)
• [x] Lethe documentation is up to date
• [x] The branch is rebased onto master
• [x] Code is indented with indent-all and .prm files (examples and tests) with prm-indent
• [x] If parameters are modified, the tests and the documentation of examples are up to date
• [x] Changelog (CHANGELOG.md) is up to date if the refactor affects the user experience or the codebase

Pull request related list:

• [x] No other PR is open related to this refactoring
• [x] Labels are applied
• [x] There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
• [x] If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
• [x] If any future works is planed, an issue is opened
• [x] The PR description is cleaned and ready for merge

[acdaigneault]

Awesome, will merge :)!

I will look into the failling test this PM, probably the rayleigh ratio :)

[blaisb]

Awesome, will merge :)!

I will look into the failling test this PM, probably the rayleigh ratio :)

Yes because the test failed after rebased Absolutely the rayleigh ratio!