chaos-polymtl / lethe

Repository for the open-source lethe CFD/DEM/CFD-DEM project
https://chaos-polymtl.github.io/lethe/index.html
GNU Lesser General Public License v2.1
269 stars 59 forks source link

Fix the critical rayleigh time step calculation in cfd-dem #1203

Closed acdaigneault closed 1 month ago

acdaigneault commented 1 month ago

Description

The critical Rayleigh time step was not properly implemented in CFD-DEM, even tho it was fixed in the past for DEM (see #776 and #939)

Solution

Changed to the same calculation as done in DEM.

Testing

Unresolved CFD-DEM application tests were modified according to the new ratio.

Documentation

Miscellaneous (will be removed when merged)

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

Pull request related list: