chaos-polymtl / lethe

Repository for the open-source lethe CFD/DEM/CFD-DEM project
https://chaos-polymtl.github.io/lethe/index.html
GNU Lesser General Public License v2.1
269 stars 59 forks source link

Fix the Coulomb's criterion in linear, Hertz, and Hertz-Mindlin with limit force in DEM #1216

Closed acdaigneault closed 1 month ago

acdaigneault commented 1 month ago

Description

The Coulomb's criterion was wrong in the particle-particle contact force for Hertz-Mindlin with limit force, Hertz and Linear. The normal force norm was explicitly positive when doing normal_force.norm(), making the Coulomb's criterion always positive even if the particles are in repulsion, so in slidling.

Solution

Apply the the same way the Hertz-Mindlin with limit overlap is calculated.

Testing

Tests with low restitution coefficient may give negative coulomb criterion, this is why some tests have changed.

Documentation

Miscellaneous (will be removed when merged)

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

Pull request related list:

blaisb commented 1 month ago

@acdaigneault can you add a CHANGELOG entry then I would merge