chaos-polymtl / lethe

Repository for the open-source lethe CFD/DEM/CFD-DEM project
https://chaos-polymtl.github.io/lethe/index.html
GNU Lesser General Public License v2.1
269 stars 59 forks source link

Modify some classes to functions and struct in DEM #1232

Closed acdaigneault closed 1 month ago

acdaigneault commented 1 month ago

Description

Some classes should not has been classes but functions or struct. I modified those classes to a more coherent architechture. I also gathered all the particle-object contact info structures in one file because it is more convenient that having 3 files for small structs.

Testing

Unit tests have been change according to that.

Miscellaneous (will be removed when merged)

I do not think that needs a change log. The particle-wall contact info needs to be changed as other, but I will do it when modifying the particle-wall forces.

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

Pull request related list:

blaisb commented 1 month ago

Some tests seem to be crashing but it seems to be due to a deal.II update. I'll try to work on this tomorrow AM

blaisb commented 1 month ago

@acdaigneault can you rebase, this way we will be able to see what is breaking because of previous bugs and not

blaisb commented 1 month ago

@acdaigneault I'm not sure what is this hang error you are getting, but it seems something is off since it happens in both release and debug?

acdaigneault commented 1 month ago

@acdaigneault I'm not sure what is this hang error you are getting, but it seems something is off since it happens in both release and debug?

Yes this is related to my PR